Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 4, 2025

What do these changes do?

This PR adds a new "Contact" section to the user profile page to display personal contact information including institution, address, city, state, country, and postal code. The changes implement read-only display of contact data that is fetched from the user profile.

ContactInfo

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this Sep 4, 2025
@odeimaiz odeimaiz added this to the Cheops milestone Sep 4, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Sep 4, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2025

🧪 CI Insights

Here's what we observed from your CI run for 1657437.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI system-tests Base branch is healthy, but retries were needed. Could be early signs of flakiness 👀 Healthy 1 View View

@odeimaiz odeimaiz requested a review from Copilot September 4, 2025 13:59
@odeimaiz odeimaiz marked this pull request as ready for review September 4, 2025 13:59
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Display My personal info 🎨 [Frontend] Display My Contact information Sep 4, 2025
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Display My Contact information 🎨 [Frontend] Display Contact information Sep 4, 2025

This comment was marked as outdated.

@odeimaiz odeimaiz requested a review from Copilot September 4, 2025 14:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new "Contact" section to the user profile page to display personal contact information including institution, address, city, state, country, and postal code. The changes implement read-only display of contact data that is fetched from the user profile.

  • Adds a new contact information section with read-only form fields
  • Extends the User model to include contact-related properties
  • Refactors section creation to use a shared helper method

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
ProfilePage.js Adds new contact section with read-only fields, refactors section creation, and integrates contact data binding
User.js Extends user model with contact properties (institution, address, city, state, country, postalCode)

@odeimaiz odeimaiz requested review from GitHK and pcrespov September 4, 2025 14:20
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POssible extras:

  • when dialog is too big ... a button to jump to the end of the dialog
  • collapsable sections (check gitlab settings sections)
    image (with doc if collapsed)
  • doc, doc, doc :-) Every entry field could have a tooltip on hover or info icon
  • All sections should be reachable by links (using in-page fragment e.g. osparc.io#/settings/profile). They will be very handy to point to part of the front-end in the support channel

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2025

@odeimaiz odeimaiz enabled auto-merge (squash) September 4, 2025 15:24
@odeimaiz odeimaiz merged commit cca8054 into ITISFoundation:master Sep 4, 2025
108 of 110 checks passed
@pcrespov
Copy link
Member

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants